PHP Issue

[Mr Macro]

When i try to echo out of the database, it echos nothing with no error.


<?php
if(!$_GET[category]){
echo('
<a href="products.php?category=soccer">Soccer Trophies</a>
<br />

');
}else{

$query = "SELECT * FROM catalogue WHERE category = '$_GET[category];'";

$result = mysql_query($query) or die(mysql_error());

$row = mysql_fetch_array($result) or die(mysql_error());

echo("

<table border='1'>
<tr>
<td><img src='images/".$row[item_number].".JPG'></td>
</tr>
<br>
<tr>
<td>Item Number: ". $row['item_number']."</td>
</tr>
</tr><br>
<tr><td>".$row[price]." GBP (Great Brittish Pounds)</td></tr>
<br>
</table>
<br>
");
}
?>

[Blob]

<?php
if( $_GET[category] == "" )
{
echo '<a href="products.php?category=soccer">Soccer Trophies</a> <br />
';
}
else
{
$query = mysql_query( "SELECT * FROM `catalogu`e WHERE category = '{$_GET[category]}'" );
while( $row = mysql_fetch_array( $result ) )
{
echo '<table border="1">
<tr>
<td><img src="images/' . $row[item_number] . '.JPG"></td>
</tr>
<br />
<tr>
<td>Item Number: ' . $row['item_number'] . '</td>
</tr>
<br />
<tr>
<td>' .$row[price] . " GBP (Great Brittish Pounds)</td></tr>
<br />
</table>
<br/>
';
}
}
?>

[Invent]

Ryan's was incorrect so:



<?php
if( $_GET[category] == "" )
{
echo '<a href="products.php?category=soccer">Soccer Trophies</a> <br />
';
}
else
{
$query = mysql_query( "SELECT * FROM `catalogue` WHERE category = '{$_GET[category]}'" );
while( $row = mysql_fetch_array( $result ) )
{
echo '<table border="1">
<tr>
<td><img src="images/' . $row[item_number] . '.JPG"></td>
</tr>
<br />
<tr>
<td>Item Number: ' . $row['item_number'] . '</td>
</tr>
<br />
<tr>
<td>' .$row[price] . ' GBP (Great Brittish Pounds)</td></tr>
<br />
</table>
<br/>
';
}
}
?>

[Blob]

My mistake - soz

[Mr Macro]

Its still blank.Im confused.

[Sygon..]

Make sure the tables & rows exists.

[Eric30]

<?php
if( $_GET[category] == "" )
{
echo '<a href="products.php?category=soccer">Soccer Trophies</a> <br />
';
}
else
{
$query = mysql_query( "SELECT * FROM `catalogu`e WHERE category = '{$_GET[category]}'" );
while( $row = mysql_fetch_array( $query ) )
{
echo '<table border="1">
<tr>
<td><img src="images/' . $row[item_number] . '.JPG"></td>
</tr>
<br />
<tr>
<td>Item Number: ' . $row['item_number'] . '</td>
</tr>
<br />
<tr>
<td>' .$row[price] . " GBP (Great Brittish Pounds)</td></tr>
<br />
</table>
<br/>
';
}
}
?>

[Eric30]

Cant Edit Last Post,

Sorry, i was tired when i looked at that and that wont work either lol,

This will work:


<?php
if( $_GET['category'] == "" ){
echo '<a href="products.php?category=soccer">Soccer Trophies</a> <br />';
}else{
$category = $_GET['category'];
$query = mysql_query( "SELECT * FROM `catalogue` WHERE category = '$category'" );
while( $row = mysql_fetch_array( $query ) ){
echo '<table border="1">
<tr>
<td><img src="images/' . $row['item_number'] . '.JPG"></td>
</tr>
<br />
<tr>
<td>Item Number: ' . $row['item_number'] . '</td>
</tr>
<br />
<tr>
<td>' .$row['price'] . ' GBP (Great Brittish Pounds)</td></tr>
<br />
</table>
<br/>';
}
}
?>

[Mr Macro]

No, still doesn't work.

[Eric30]

Try this and tell me the error which it says:


<?php
if( $_GET['category'] == "" ){
echo '<a href="products.php?category=soccer">Soccer Trophies</a> <br />';
}else{
$category = $_GET['category'];
$query = mysql_query( "SELECT * FROM `catalogue` WHERE category = '$category'" ) or die("MySQL Error: <br>".mysql_error());
while( $row = mysql_fetch_array( $query ) ){
echo '<table border="1">
<tr>
<td><img src="images/' . $row['item_number'] . '.JPG"></td>
</tr>
<br />
<tr>
<td>Item Number: ' . $row['item_number'] . '</td>
</tr>
<br />
<tr>
<td>' .$row['price'] . ' GBP (Great Brittish Pounds)</td></tr>
<br />
</table>
<br/>';
}
}
?>

[Invent]

If thats the WHOLE code of the file, make sure you're including the file which contains your database information.

[ScottDiamond.]

If thats the WHOLE code of the file, make sure you're including the file which contains your database information.

Ditto. config.php, for example.

[*]

WOW that code is SO insecure.
By having a GET variable directly inputted into a query is suicide.
That easily allows SQL injection and could delete the whole of your database.
TOTAL FIX + SECURITY FIX:



<?php
if(empty($_GET['category']) == true) {
echo "<a href="products.php?category=soccer">Soccer Trophies</a><br />"; }else{
$cat = addslashes($_GET['category']);

$query = mysql_query("SELECT * FROM catalogue WHERE category = '$cat'");

if(mysql_error()) {
print(mysql_error());
}

while($row = mysql_fetch_array($query)) {
echo("

<table border='1'>
<tr>
<td><img src='images/".$row[item_number].".JPG'></td>
</tr>
<br>
<tr>
<td>Item Number: ". $row['item_number']."</td>
</tr>
</tr><br>
<tr><td>".$row[price]." GBP (Great Brittish Pounds)</td></tr>
<br>
</table>
<br>
");
}
?>



Rep if this works :rolleyes:

[Jamie.]

<?php
$conn = mysql_connect("localhost","USERNAME","PASSWORD");
mysql_select_db(DATABASENAME) or die(mysql_error());
if(empty($_GET['category']) == true) {
echo "<a href="products.php?category=soccer">Soccer Trophies</a><br />"; }else{
$cat = addslashes($_GET['category']);

$query = mysql_query("SELECT * FROM catalogue WHERE category = '$cat'");

if(mysql_error()) {
print(mysql_error());
}

while($row = mysql_fetch_array($query)) {
echo("

<table border='1'>
<tr>
<td><img src='images/".$row[item_number].".JPG'></td>
</tr>
<br>
<tr>
<td>Item Number: ". $row['item_number']."</td>
</tr>
</tr><br>
<tr><td>".$row[price]." GBP (Great Brittish Pounds)</td></tr>
<br>
</table>
<br>
");
}
?>

[ScottDiamond.]

<?php
$conn = mysql_connect("localhost","USERNAME","PASSWORD");
mysql_select_db(DATABASENAME) or die(mysql_error());
if(empty($_GET['category']) == true) {
echo "<a href="products.php?category=soccer">Soccer Trophies</a><br />"; }else{
$cat = addslashes($_GET['category']);

$query = mysql_query("SELECT * FROM catalogue WHERE category = '$cat'");

if(mysql_error()) {
print(mysql_error());
}

while($row = mysql_fetch_array($query)) {
echo("

<table border='1'>
<tr>
<td><img src='images/".$row[item_number].".JPG'></td>
</tr>
<br>
<tr>
<td>Item Number: ". $row['item_number']."</td>
</tr>
</tr><br>
<tr><td>".$row[price]." GBP (Great Brittish Pounds)</td></tr>
<br>
</table>
<br>
");
}
?>

No they would have to inculde the config.

[Jamie.]

yeh but i was just showing -.- so neh :P

[Tomm]

Create a file with this and include all the configs, etc.



<?php
require_once('myconfig.php');

$query = "SHOW TABLES;";
$res = mysql_query($query) or die (mysql_error());
$rows = mysql_fetch_assoc($res);
do {
var_dump($rows);
} while($rows = mysql_fetch_assoc($res));

?>


If this returns nothing then there is a problem on the MySQL side, is it returns all the tables in the current database there is a problem with your script.

[*]

Jamie why take my code :S

[Jamie.]

i adapted it actually ;)

[Blob]

$conn = mysql_connect("localhost","USERNAME","PASSWORD");
mysql_select_db(DATABASENAME) or die(mysql_error());



Jamie why take my code :S

You talking about that? Because that aint your code, so he can use it all he likes.

[Jamie.]

You talking about that? Because that aint your code, so he can use it all he likes.

hey ryan nice to see you around :p

[Blob]

hey ryan nice to see you around :p

Hey xD

Have you found a code that works yet :S?

[Jamie.]

Hey xD

Have you found a code that works yet :S?

Sorry its not my code :)
but me u n george shud meet :P someday haha