PDA

View Full Version : Do i code badly?


kk.
22-01-2008, 06:48 PM
Im just wondering if i code badly because ive been learning how to code pretty much from tutorials and by myself and i was just wondering if the way i code stuff is bad.

here is an example: http://cheatssource.co.uk/clubtropica/sliced/home.html


<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1" />
<title>Untitled Document</title>
<link href="boxes.css" rel="stylesheet" type="text/css" />
<link href="text.css" rel="stylesheet" type="text/css" />
<style type="text/css">
<!--
.style3 {
font-family: Arial, "Trebuchet MS", Verdana;
font-weight: bold;
color: #FF9F5B;
}
.style4 {font-size: 1px}
body {
background-color: #FFFFFF;
}
.style5 {font-size: 9px}
-->
</style>
<body>

<div id="container">
<div id="banner">
<div align="center">
<img src="images/CT-tree.gif" width="403" height="234"><img src="images/CT-writing.gif" width="293" height="91"> </div>
</div>
<div id="main">

<div class="top"><div class="bottom"><div class="left"><div class="right"><div class="tr"><div class="tl"><div class="bl"><div class="br">

<!--start navigation-->
<!--end navigation-->
<div id="radio">
<div align="right"><img src="images/Slicing_13.gif" width="47" height="58"><img src="images/Slicing_18.png" /><img src="images/Slicing_15.png" width="48" height="58"></div><div class="bottom"></div>
</div>
<br />
<br />
<br />
<br />
<div id="content-box">

<div class="top"><div class="bottom"><div class="left"><div class="right"><div class="tr"><div class="tl"><div class="bl"><div class="br">

<div id="content-text">

<!--New users-->
<div id="new-users">
<div class="top"><div class="bottom"><div class="left"><div class="right"><div class="tr"><div class="tl"><div class="bl"><div class="br">
<div id="new-users-content">
<p class="style3">&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;Newest Users<br />
<div id="new-users-pics">
<div class="top"><div class="bottom"><div class="left"><div class="right"><div class="smalltr"><div class="smalltl"><div class="smallbl"><div class="smallbr">
<div align="right"><img src="images/no-pic.gif" width="75" height="73" />
<span class="style4">&nbsp;</span><br />
</div>
</div></div></div></div></div></div></div></div></div>
<div id="new-users-pics">
<div class="top"><div class="bottom"><div class="left"><div class="right"><div class="smalltr"><div class="smalltl"><div class="smallbl">
<div class="smallbr">
<div align="right"><img src="images/no-pic.gif" width="75" height="73" />
<span class="style4">&nbsp;</span><br />
</div>
</div>
</div></div></div></div></div></div></div></div>
<p><br />
<br />
<br />
</p>
<p class="style5"><br />
<div id="new-users-pics">
<div class="top"><div class="bottom"><div class="left"><div class="right"><div class="smalltr"><div class="smalltl"><div class="smallbl"><div class="smallbr">
<div align="center"><img src="images/no-pic.gif" width="75" height="73" />
<span class="style4">&nbsp;</span><br />
</div>
</div></div></div></div></div></div></div></div></div>
<div id="new-users-pics">
<div class="top"><div class="bottom"><div class="left"><div class="right"><div class="smalltr"><div class="smalltl"><div class="smallbl"><div class="smallbr">
<div align="right"><img src="images/no-pic.gif" width="75" height="73" />
<span class="style4">&nbsp;</span><br />
</div>
</div></div></div></div></div></div></div></div></div>
</p>
<p>&nbsp;</p>
<p><br />
<br />
<br />
</p>
</div>
</div>
</div></div></div></div></div></div></div>
</div>
<!-- Content-->
<span class="style1">Welcome</span><br />
<span class="style2">We at ClubTropica Villas welcome you to your holiday retreat. Where you can create your own free, 3D villa and also create profile pages and interact with other members by leaving comments and messages on their pages. If you want to go to clubtropica, then just click here.</span><br />
<br />
<span class="style1">What we&rsquo;re about</span><br />
<span class="style2">A few of you may be wondering what we&rsquo;re actually about. Some may call us a fansite to ClubTropica. Well, our main existence is to give everyone the chance to enjoy ClubTropica withoutt he extra expenditures. This means that you will each be given a set amount of Isla&rsquo;s which you can spend on what you like from stickers to furniture. You will also get chances to win some Isla&rsquo;s by entering competitions. The second way to earn Isla&rsquo;s is by commenting and being active on the website. There are more ways to earn and I am sure you will find them outa s you browse the website. We also have a news feature which will keep you up to date with whats happening on ClubTropica and when new features are available. </span>
<p class="style2"><span class="style1">A final note...</span><br />
Thank you once again for visiting ClubTropica Villas and we all hope that you enjoy your time here. Browse the site and you never know when you may come across a surprise and a new feature.</p>
<p class="style2">Thanks for your interest<br />
<strong>ClubTropica Villas</strong></p>
<br />
</div>

</div>
</div></div></div></div></div></div></div>
<br />
</div>
</div>
</div>
</div></div></div></div></div></div></div>

<div class="style2" id="footer">
<div id="footertext">
<div align="right">home | contact us | top | radio | request</div>
</div>
</div>
</div>
<!-- end of container -->
</div>

<!-- end of container -->
</div>
</div>

</body>
</html>



oh btw, ignore the syle at the top, i forgot to move that :)
Breakfloor
22-01-2008, 06:53 PM
i dont code. but that looks wrong to me?
Warezkid2
22-01-2008, 06:54 PM
It seems abit too much ? :S
Jamie.
22-01-2008, 06:56 PM
start using stuff like
background-image: Url(); for layout images its neater imo.
kk.
22-01-2008, 06:58 PM
well what i do with borders is strange and so that gives loads of div classes.
and if i cant correct something thats going weird (say i wanted two boxes next to each other and i can t figure out why it wont work) i create another div for them :P

i think that page loaded quite fast for me? considering it has a lot of images :P

EDIT: where do you suggest background-image: fmsdjifnh ???
Blob
22-01-2008, 07:01 PM
If you have written out that, then you can't code badly. If you're talking about coding as in coding the actual HTML.

If your talking about presentation, then, yes, it should be changed. If I bought that I would want a refund. Its about layout and making it look neat. Even if it is about 500 lines long.
kk.
22-01-2008, 07:06 PM
so the code is actually ok, its just the presentation of the code thats bad. How would you suggest laying it out.
Mentor
22-01-2008, 07:47 PM
Not the cleanest code ive ever seen, kinda shows of being edited by Dw alot as well. Good indentation always makes code more readable, so work on that, other than the formatting thought it all looks ok?
kk.
22-01-2008, 07:56 PM
oh right ok. and yeh, Dw helps me out a bit :)
surely its ok if the site loads fine :P
and btw, i deleted the site, im not having the same thign happen to me again :P
--ss--
22-01-2008, 08:04 PM
You need to sort out the syntax of it all out lol.

Want to hide these adverts? Register an account for free!