PHP Gurus...

Quote:

---

Originally Posted by Blob

I use this to connect:

PHP Code:

---

class MySQL {
    public $kernel, $storedFetch;
    private $dbInfo, $dbConnection, $db, $debugConnection, $debugInfo, $storedQuery;
    
    public function __construct( $kernel )
    {
        $this->Kernel = $kernel;
        $this->dbInfo = $this->Kernel->_loadItem( "MySQL", "MySQL.php", "Database/", "Config" );
        $this->_bootDatabase();
    }
        
    private function _bootDatabase( )
    {
        if( empty( $this->dbInfo["Database"] ) !== false )
        {
            $this->Kernel->alert->displayAlert( "warning", 1003 );
            return false;
        }
        
        $dbInfo["Username"] = ( empty( $dbInfo["Username"] ) !== false ) ? "root" : $dbInfo["Username"];
        $dbInfo["Server"] = ( empty( $dbInfo["Server"] ) !== false ) ? "localhost" : $dbInfo["Server"];
        
        $this->dbConnection = @mysql_connect( $this->dbInfo["Server"], $this->dbInfo["Username"], $this->dbInfo["Password"] );
        $this->db = @mysql_select_db( $this->dbInfo["Database"] );
        
        if( $this->dbConnection === false || $this->db === false )
        {
            // Can't connect! Lets try to debug..
            $this->_debugConnection();
        }
    } 


---

---

Ok that's it I am never letting you view my code over teamviewer again.

PHP Code:

---

class Database
{
    private $kernel;
    private $_dbInfo;
    
    private $db;
    
    public function __construct( Kernel $kernel )
    {
        $this->kernel = $kernel;
        $this->_startDbConn();
    }
    
    private function _startDbConn()
    {
        # Grab the configuration info
        global $mysql;
        
        $this->_dbInfo = $mysql;
        unset( $mysql );
        
        $class = ( strtolower( $this->_dbInfo[ 'driver' ] ) === 'mysqli' ) ? 'clientMySQLi' : 'clientMySQL' ;
        
        $this->kernel->loadClass( $class, $class . '.php', '/Database' );        
        $this->db = $this->kernel->getClass( $class );
        
        $this->db->connect( $this->_dbInfo );
        
        $this->kernel->setClass( 'db', $this->db );
        //print_r($this->_dbInfo);
    }
} 


---

PHP Code:

---

class clientMySQL
{
    private $kernel;
    
    private $_conn;
    
    public function __construct( $kernel )
    {
        $this->kernel = $kernel;
    }
    
    public function connect( $sql )
    {
        $persistent = ( $sql[ 'persistent' ] === 1 ) ? 'mysql_pconnect' : 'mysql_connect';
        
        $host = ( isset( $sql[ 'port' ] ) === true and ctype_digit( $sql[ 'port' ] ) === true ) ? $sql[ 'hostname' ] . ':' . $sql[ 'port' ] : $sql[ 'hostname' ];
        
        $this->_conn = @$persistent( $host, $sql[ 'username' ], $sql[ 'password' ] );
        
        if( $this->_conn === false ) {
            errHandler::mysqlError( mysql_errno() );
        }
    }
} 


---

Quote:

---

Originally Posted by Jewish Bear

Ok that's it I am never letting you view my code over teamviewer again.

PHP Code:

---

class Database
{
    private $kernel;
    private $_dbInfo;
    
    private $db;
    
    public function __construct( Kernel $kernel )
    {
        $this->kernel = $kernel;
        $this->_startDbConn();
    }
    
    private function _startDbConn()
    {
        # Grab the configuration info
        global $mysql;
        
        $this->_dbInfo = $mysql;
        unset( $mysql );
        
        $class = ( strtolower( $this->_dbInfo[ 'driver' ] ) === 'mysqli' ) ? 'clientMySQLi' : 'clientMySQL' ;
        
        $this->kernel->loadClass( $class, $class . '.php', '/Database' );        
        $this->db = $this->kernel->getClass( $class );
        
        $this->db->connect( $this->_dbInfo );
        
        $this->kernel->setClass( 'db', $this->db );
        //print_r($this->_dbInfo);
    }
} 


---

PHP Code:

---

class clientMySQL
{
    private $kernel;
    
    private $_conn;
    
    public function __construct( $kernel )
    {
        $this->kernel = $kernel;
    }
    
    public function connect( $sql )
    {
        $persistent = ( $sql[ 'persistent' ] === 1 ) ? 'mysql_pconnect' : 'mysql_connect';
        
        $host = ( isset( $sql[ 'port' ] ) === true and ctype_digit( $sql[ 'port' ] ) === true ) ? $sql[ 'hostname' ] . ':' . $sql[ 'port' ] : $sql[ 'hostname' ];
        
        $this->_conn = @$persistent( $host, $sql[ 'username' ], $sql[ 'password' ] );
        
        if( $this->_conn === false ) {
            errHandler::mysqlError( mysql_errno() );
        }
    }
} 


---

---

Actually, I coded that without seeing your MySQL Class ever, its only your Kernel I have seen.

Oh, I hear my roflcopter engine startin', come aboard har har har.

Ontopic: OOP is quite easy to get the hang of it, when you understand the basics my friend. You should check out php.net.

Show Hide

I wrote that, so I didn't get an infraction, BUT I SEE ONE COMING

Why are you typecasting everything? It's completely unnecessary.

Quote:

---

Originally Posted by Protege

PHP Code:

---

class database
{
    public $core;
    
    public function connect()
    {
        $dbConnect = ( bool ) mysql_connect( $this->core->__dbHost, $this->core->__dbUsername, $this->core->__dbPassword );
        
        if( $dbConnect !== TRUE )
        {
            $this->core->___errorMessage = ( string ) $this->core->languages->___language( 'DbBadConnect' );
            return FALSE;
        }
        
        $dbSelectDb = ( bool ) mysql_select_db( $this->core->__dbDatabase );
        
        if( $dbSelectDb !== TRUE )
        {
            $this->core->___errorMessage = ( string ) $this->core->languages->___language( 'dbBadDatabase' );
            return FALSE;
        }
        
        return TRUE;
    }
/* ...... */
} 


---

ya can do that instead if you want to.

---

Bcuz its good practice... even though PHP auto interprets it all.

Quote:

---

Originally Posted by Protege

Bcuz its good practice... even though PHP auto interprets it all.

---

It's only good practice in certain circumstances..not when the returned value is always going to be a specific data type.

And when I've used it, the values could return a different type than specified.

Quote:

---

Originally Posted by Protege

And when I've used it, the values could return a different type than specified.

---

PHP Code:

---

$dbConnect = ( bool ) mysql_connect( $this->core->__dbHost, $this->core->__dbUsername, $this->core->__dbPassword ); 


---

Useless, it will return boolean false if there's an error so you typecast it then check to make sure it's not true :eusa_thin

PHP Code:

---

$dbSelectDb = ( bool ) mysql_select_db( $this->core->__dbDatabase ); 


---

Useless, it will always return a boolean type :eusa_thin

I agree on the second part but on the first I have a mixed opinion.

However Ive used an if statement to check that it isn't true, so it is useless in that instance, unless I was to check it was equal to true it would be the correct way.

This isn't really helping the thread starter. This is way too complex for a begginner. Seriously.