[PHP] Help please.

[RedCrisps]

why won't this code work, so the password changes:

<?php
if(isset($_SESSION["EON_CNTPNL_USERNAME"]))
{ $check->login(); }
else{
session_start();
include("functions.php");
$check = new checklogin;
$check->login(); }
echo("
                  <b>Edit your password!</b><br/>
                 <br/>");
if($_GET["act"] == "update")
{
    $password = clean($_POST["password"]);
    $password2 = md5($password);
$password2 = sha1($password2);
    mysql_query("UPDATE `users` SET `password` = '$password2' WHERE `username` = '{$_SESSION["panel_username"]}'");
    echo("Password Updated");
    exit;
}
else
{
    $rand = generateRandStr(13);
    echo("Please set a new password:<br/><form action=\"?page=editpass&act=update\" method=\"POST\"><input type=\"text\" name=\"password\" value=\"$rand\" class=\"formbox\"> <b><-- Suggested</b><br/><br/><input type=\"submit\" name=\"submit\" value=\"Change Password\"><br/><br/>
    The suggested password was $rand<br/>(So you can copy and paste)</form>");
}
?>

[Flisker]

And whats the error?

[RedCrisps]

The password won't change

[MrCraig]

Change..

mysql_query("UPDATE `users` SET `password` = '$password2' WHERE `username` = '{$_SESSION["panel_username"]}'"); 

To

mysql_query("UPDATE `users` SET `password` = '$password2' WHERE `username` = '$_SESSION[EON_CNTPNL_USERNAME]'"); 

That should work

[MountainDew]

<?php
if(isset($_SESSION["EON_CNTPNL_USERNAME"]))
{ $check->login(); }
else{
    session_start();
    include("functions.php");
    $check = new checklogin;
    $check->login(); }
    echo("
                  <b>Edit your password!</b><br/>
                 <br/>");
    if($_GET["act"] == "update")
    {
        $password = clean($_POST["password"]);
        $password2 = md5($password);
        $password2 = sha1($password2);
        $username = $_SESSION["panel_username"];
        mysql_query("UPDATE `users` SET `password` = '$password2' WHERE `username` = '$username'") or die(mysql_error());
        echo("Password Updated");
        exit;
    }
    else
    {
        $rand = generateRandStr(13);
        echo("Please set a new password:<br/><form action=\"?page=editpass&act=update\" method=\"POST\"><input type=\"text\" name=\"password\" value=\"$rand\" class=\"formbox\"> <b><-- Suggested</b><br/><br/><input type=\"submit\" name=\"submit\" value=\"Change Password\"><br/><br/>
    The suggested password was $rand<br/>(So you can copy and paste)</form>");
    }
?>

[RedCrisps]

ty for the help i will try as soon as i get my laptop back

[MrCraig]

Caleb, thats the same as the first version?

panel_username isnt the session variable :rolleyes:

[MountainDew]

Caleb, thats the same as the first version?

panel_username isnt the session variable :rolleyes:

How do you know that? Its included in his version, also it is not the same as the first version, the first version has no error handling.


You don't know that is not the session, at the top it gives another session to check against, but that doesn't mean the same...

[MrCraig]

Buy surely dan wouldnt set 2 username variables?

[Hitman]

Yeah I noticed the var $password 2 is being used twice, maybe that's a problem?