Php help

[dobbin]

Can any of you see a problem with this script?

<?php

$user_name = $_POST["user_name"];
$password = $_POST["password"];
$admin = $_POST["admin"];

if( $admin == 'on' ) {
    $admin = 1;
} else {
    $admin = 0;
}

echo $user_name.','.$password.','.$admin;

//echo $user_name;

if( $user_name == '' or $password == '' ) {
    header( 'location: create_user.html' );
}

$user = 'temp_admin';
$password = '';
$host = 'localhost';
$database = 'security';

$cxn = mysqli_connect( $host, $user, $password, $database )
    or die( 'Could not connect to database' );

$sql = "insert into user ( user_name, password, admin )
        values ( '" .$user_name. "', '" .$password. "', " .$admin. " )";

$result = mysqli_query( $cxn, $sql );

echo "Created user ".$user_name;

?>

[Calon]

echo $user_name;
echo $password;
echo $admin; 

[Jxhn]

It would help if you told us what's going wrong.

[dobbin]

Ok you can sign normal people up but when you wont to sign a admin up it doesn't work

[Decode]

Are you sure you are posting $_POST['admin'] as "on"?

[Invent]

<?php

$user_name = $_POST[ 'user_name' ];
$password = $_POST[ 'password' ];
$admin = $_POST[ 'admin' ];

if( $admin == 'on' )
{

    $admin = '1';

}
else
{

    $admin = '0';
    
}

echo $user_name . ',' . $password . ',' . $admin;

//echo $user_name;

if( $user_name == '' || $password == '' )
{

    header( 'Location: create_user.html' );
    die;
    
}

$user = 'temp_admin';
$password = '';
$host = 'localhost';
$database = 'security';

$cxn = mysqli_connect( $host, $user, $password, $database ) or die( 'Could not connect to database' );

$sql = "INSERT INTO `user` ( `user_name`, `password`, `admin` ) VALUES ( '" . $user_name . "', '" . $password . "', '" . $admin . "' )";

$result = mysqli_query( $cxn, $sql );

echo 'Created user ' . $user_name;

?>

That should work...if not please tell me/us the error.

[Calon]

I hate it when people capitalize the first letter of php and leave the rest in lowercase

Sorry, but your explanation really didn't help me, Simon's code looks like it should work, I haven't seen it, but yeah..

[Hypertext]

I hope your not basing administrator abilities on a post, fyi this could easily be spoofed.

[Kyle!]

I hope your not basing administrator abilities on a post, fyi this could easily be spoofed.

Ah... Looks like he is.

[Source]

It shouldn't be a problem, as this looks like its in an admin control area... its for making users and not logging in etc...