Not adding to the DB [PHP]

[loserWILL]

9c5c7e79a2d17ca57911871290a4e8a6 > That user does not exist.

What the - that user does exist.

[Invent]

Could you add a die() under the echo I added sorry! If it outputs "9c5c7e79a2d17ca57911871290a4e8a6 >" then obviously the issue is $c_pass doesn't have a value.

Thanks,
Simon

[loserWILL]

"1That user does not exist. "

And the 'die' code should be:

echo ( $password . ' > ' . $c_pass ) or die(); 

right?

[Invent]

Hi,

Sorry, the code at the moment should be:

<?php 

if($logged['in'] === 1){
    header("Location: index.php");
}

if($_POST['login']){
    $username = clean($_POST['username']);
    $password = clean($_POST['password']);
    $password = enc($password);
    
    $errors = 0;
    $error_message = '';
    
    if(empty($username) || empty($password)){
        $errors++;
        $error_message = 'Both fields must be filled in.';
    }
    
    if(!row_exists('users','username','$username')){
        $errors++;
        $error_message = 'That user does not exist.';
    } else{
        $query = mysql_query("SELECT `id`, `username`, `password` FROM `users` WHERE `username` = '".$username."' LIMIT 1");
        $u = mysql_fetch_object($query);
    }
    
    if($u->password_reset == $password){
        $c_pass = $u->password_reset;
        $update = mysql_query("UPDATE `users` SET `password`='".$c_pass."', `password_reset`='' WHERE `id`='".$u->id."' LIMIT 1");
    } else {
        $c_pass = $u->password;
        $update = mysql_query("UPDATE `users` SET `password`='".$c_pass."', `password_reset`='' WHERE `id`='".$u->id."' LIMIT 1");    
    }
    
    if($password != $c_pass)
    {
        
        echo ( $password . ' > ' . $c_pass );
        die();

    }
    
    if($errors == 0){
        $_SESSION['id'] = $u->id;
        $_SESSION['username'] = $u->username;
        $_SESSION['password'] = $u->password;
        
        header("Location: index.php");
    } else{
        echo $error_message;
    }
        
    }
?>

Please report back the results

-Invent

[loserWILL]

Ooh, stupid me. ;l

9c5c7e79a2d17ca57911871290a4e8a6 >

[Invent]

Hi,

So the issue is $c_pass has no value, which means the error lies in this block of code:

    if($u->password_reset == $password){
        $c_pass = $u->password_reset;
        $update = mysql_query("UPDATE `users` SET `password`='".$c_pass."', `password_reset`='' WHERE `id`='".$u->id."' LIMIT 1");
    } else {
        $c_pass = $u->password;
        $update = mysql_query("UPDATE `users` SET `password`='".$c_pass."', `password_reset`='' WHERE `id`='".$u->id."' LIMIT 1");    
    } 

Please check over your MySQL database structure to see if you can find the error.

I've got to go now (to sleep - it's 4:33AM here!), if you can't fix it I'll help you tomorrow

Thanks,
Invent

[loserWILL]

Alrighty, thanks for the help. (I'll post tomorrow morning if I've fixed it or not - probably not as I'm going to sleep now too)

[loserWILL]

Yeah, I still need help. I tried a couple things before I went to sleep and none of them worked.

[Agnostic Bear]

Your problem is here:

!row_exists('users','username','$username') 

'' will treat the string as literal, i.e it will check for "$username" not "Bill" or "Hello", remove the quotes and it should work.

!row_exists('users','username',$username) 

You might also want to consider changing this:

`username` = '".$username."' 

To this:

`username` LIKE '".$username."' 

for case insensitive matching of usernames, also you'll want to change % to \% and _ to \_ in your mysql cleaning function to stop wildcards.

[Invent]

Instead of using a LIKE statement like Dan suggested you could just change

 `username` = '".$username."' 

to

 LOWER( `username` ) = '". strtolower( $username )."' 

I'm not completely sure if Dan's method is more efficient, but this way you wouldn't have to deal with cleaning the $username variable against SQL vulnerabilities through the LIKE statement.

Thanks,
Invent