Php help

[Hypertext]

If it is, an $admin variable wouldn't be needed, as we'd already know it was in the admin control area.

[Source]

This is for making users charlie... am I been thick or something? At the moment it seems to be you...

This is for making users, the admin variable is to determine if that user would have admin rights, it then stores the details in the database. $admin related to the admin column.

[Dentafrice]

I hope your not basing administrator abilities on a post, fyi this could easily be spoofed.

If it is, an $admin variable wouldn't be needed, as we'd already know it was in the admin control area.

Can you really not interpret something as easy as that?

It's a checkbox.. on/off? if checkbox is on, do you not get that?

I mean.. you're a professional coder.. you should understand that?

It's not posting permissions?! That would be stupid.

[Hypertext]

In which case, I'll change my point. Somebody could easily navigate to this page and send a spoofed $_POST array, thus adding themselves a user, which is dangerous, regardless of whether the page with the form is secure.

[Source]

and the chances of that person knowing what the structure of the site is, and what the file name would be?

[Dentafrice]

I'm pretty damn sure, that isn't all of his code.

<?php
include "config.php";

$core->user->requireLogin();
$core->user->requireAdmin();

$action = $_GET ["action"];

switch($action) {
    
}
?>

Couldn't spoof that.

Plus he isn't asking for if it is secure or not, he's asking what's the matter with it.

[Hypertext]

I'm pretty damn sure, that isn't all of his code.

<?php
include "config.php";

$core->user->requireLogin();
$core->user->requireAdmin();

$action = $_GET ["action"];

switch($action) {
    
}
?>

Couldn't spoof that.

Plus he isn't asking for if it is secure or not, he's asking what's the matter with it.

Where did that code come from?

And we're inferencing that. You could easily have made bad functions. of requireLogin() and requireAdmin().

[Dentafrice]

It was an example..?

of course I could have.. but I didn't.. :rolleyes:

[Source]

Twinkies.