[RELEASE] Habbo Site Panel 3.0

[DeejayMachoo$]

Okay, I'm going to go through this. I'm going to flame you. Take my criticism or not, the choice is yours.

Indent your code, seriously.. that's the first mistake you made, was to code this sloppy

$login = new login;
$user = new user;
$security = new security;
$panel = new panel;
$frontend = new frontend; 

This is PHP.. when you're creating objects.. don't just use "login", use "login()", it's an object.

Your variables are named like ****.. it's words that are crumbled up.. plus you're putting stupid things are variables, that should be put as constants..

$lightertablebg = '#D2D2D2';
$evenlightertablebg = '#E5E5E5';
$darkertablebg = '#000000'; 

Look at those variable names! My god..

Could try something like this:

$lighter_table_bg
$even_lighter_table_bg
$darker_table_bg

That still looks like ****.

$bg_lighterTable
$bg_evenLighterTable
$bg_darkerTable

That looks nicer, because you're separating your variables into categories, in this case bg_. Same with desktop programming, and the naming conventions there (lblBla, txtBla, grpBla, radBla).

Example:

define("BG_LIGHTER", "#D2D2D2"); 

Usage:

echo BG_LIGHTER; 

-----------------------------------

Another thing, you're creating all these instances of classes at the first of your program, which is really stupid.

Create only the instances you need, when you need them.

Something that you'll probably need globally, a lot of the time, would be your "security" class.

That class is absolutely ******* stupid.. it's TWO FUNCTIONS.. and you're wasting time creating a class for it.

Could you just not have a main "core" that this entire program is structured around?

You don't need an entire class to clean a string.. plus you have an "updatesetting" function inside of your security class? wth?

You're naming conventions on functions are also awful.. makesafe?

Who the hell is going to develop on something with such badly name functions.

make_safe, makeSafe, MakeSafe looks a tad bit better, and easier to read through then just makesafe. It looks like one word.

---------------------------

Half of your classes only have like one function in them, pointless? Yeah.. very much so.

class frontend {


public function getslot($var, $var1) {
global $user;
$getslot = mysql_query("SELECT * from `timetable` WHERE `day` = '$var'");
$slot = mysql_fetch_array($getslot);
if ($slot[$var1] == '') {
echo("<td bgcolor=\"#D5D5D5\" align=\"center\">&nbsp;</td>"); 
} else { 
echo("<td bgcolor=\"#398FDF\" style=\"color:#FFFFFF\" align=\"center\">$slot[$var1]</td>");
}
}

} 

I mean what the hell? What the hell.. it's absolutely awful.

------------------------------

I can't even be arsed to go through it anymore, the coding is awful, awful, awful.

You're attempting to create something object oriented, but I don't really think you get the concept or how things actually work in this sense.

I don't see how you could look at that code, and actually see it fit to release, when you know good and well it isn't your best, or it isn't fit to even be looked at.

If you ever want anyone to expand on this panel, make useful "modifications" to it, or even look at the coding more then 2 seconds (which I don't see how I did it), then you need to take time to actually put an effort into it.. instead of settling for a pile of ****, which is what this is.

Anyone who is going to want to change anything, the look, etc, is going to have to dig through ******-ass coding to change one little color code, which you used wrong.. half the time you didn't put a # before the code, and two lines down you did..

You're an inconsistant coder, that needs more experience for even attempting to release something like this..

You said the other panel was awful? I'd hate to see it.

Indent your code, indent it, don't use stupid-ass classes that are pointless that are un-needed, work on naming things way way better, use some logic!

Logic.

Logic.

Logic.

All in all, it sucks.. I'm sorry, thanks for "attempting" to contribute something to the community, but if you can't contribute something work even looking at the internal workings, it's really not a good contribution at all.

Welcome to the D&D Section.

Wahoo thankyou Your the first person who i concider "expert" who has given me constructive criticism , but as i said in my first post i didn't recently code this i coded it a good 5months ago and wanted your opinions ect, bugs, errofs, faults then i will tidy up my code and release a better version one, well you get the picture, all bug fixes tider code and hopefully something that the "expert" community can handel.

[RyanDOT]

Hey, i rather like it, never used HSP 1 or 2, but this one looks unique..

Try adding a events script like the DJ one, where they book it.

[Dentafrice]

Wahoo thankyou Your the first person who i concider "expert" who has given me constructive criticism , but as i said in my first post i didn't recently code this i coded it a good 5months ago and wanted your opinions ect, bugs, errofs, faults then i will tidy up my code and release a better version one, well you get the picture, all bug fixes tider code and hopefully something that the "expert" community can handel.

Buddy, that code don't need "tidying" up, that code needs rewritten from scratch, it's a pile of ****.

IF you cannot handle the "bug fixes" yourself, then you shouldn't release it and "let the expert community" fix them, that's your job, not ours.

[UrbanRyan]

Looks great - well done.

[Chippiewill]

dentafrice, do you have a hangover or something, you seemed to be an angry drunk last night. Now you seem iritable here. Also he coded it a while back, not everyone is brilliant at php and who gives a damn what the variable is called, sure it's orginisation but is it going to speed up the script? I doubt it.

[Invent]

dentafrice, do you have a hangover or something, you seemed to be an angry drunk last night. Now you seem iritable here. Also he coded it a while back, not everyone is brilliant at php and who gives a damn what the variable is called, sure it's orginisation but is it going to speed up the script? I doubt it.

It's not about speeding up the script, it's about making it a good base for developers to expand on.

[DeejayMachoo$]

It's not about speeding up the script, it's about making it a good base for developers to expand on.

eek sorry didnt reply for a day or 2 was away but by tidying up i ment basicly fix bugs and change the coding in places where people have said it was badly coded

[Dentafrice]

eek sorry didnt reply for a day or 2 was away but by tidying up i ment basicly fix bugs and change the coding in places where people have said it was badly coded

In "places" it is badly coded? The entire panel is badly coded.. the entire thing. Not just "places".

[DeejayMachoo$]

In "places" it is badly coded? The entire panel is badly coded.. the entire thing. Not just "places".

CALM DOWN DEAR ITS ONLY A COMMERCIAL

Wow i didnt know i would get hit so hard in the face for giving something away that was hidden in the deep depths of my computer, next time i have something unused ill just delete it ok?

[habtasia]

Off Topic: Matt, did you get the sql done for the you know what

On Topic: Great design, well done!