Habbox / Habboxlive design

[Recursion]

It gets worse than that, a variable which stores the number of minutes was "$hours"

Edited by Martin (Forum Super Moderator): Please do not make pointless posts

[HotelUser]

It gets worse than that, a variable which stores the number of minutes was "$hours"

And that constitutes as having to save my sorry ass? Go ahead and code some thousands of lines and not make one or two silly mistakes, I dare you.

Although I'm curious, I just looked through all my on record HxHD prefixed pages and couldn't find any variable called $hours that I used anywhere, which file and line was that in?

[The Don]

Although I'm curious, I just looked through all my on record HxHD prefixed pages and couldn't find any variable called $hours that I used anywhere, which file and line was that in?

Warning contains swear word

Show Hide

[/QUOTE]

Edited by Martin (Forum Super Moderator): Please do not make pointless posts

[GoldenMerc]

While were on faults, bugs, problems with Habbox. Can i ask whats being done about the sms donator...

[The Don]

While were on faults, bugs, problems with Habbox. Can i ask whats being done about the sms donator...

I second this @HotelUser;

Now I'm actually off to bed night

[GoldenMerc]

I second this @HotelUser;

Now I'm actually off to bed night

not a coding problem, its a matt garner issue

[xxMATTGxx]

While were on faults, bugs, problems with Habbox. Can i ask whats being done about the sms donator...

The legal team are dealing with the issue.

[GoldenMerc]

another glpayment situation?
legal team hehe

[HotelUser]

had to save your sorry ass. You were dividing minutes by sixty and then rounding, not flooring on the HxHD check-in system thingy. 35 minutes somehow ended up as an hour and 35 minutes.


That commenting was unclear to just about anyone reading it who wasn't yourself.

There's a security need to prevent XSS, saw some vulnerabilities you didn't bother fixing (You also didn't prevent non team leaders viewing other staff on the weekly overview).

Good Morning!

Since you started this argument I'd like to take this opportunity to end the argument but not without first clearing a few things up.

1. Starting a public argument on the fansite with no other objective other than to attack another person's abilities (whether that be ability to code, manage a department, design graphics, etc) is what I would consider very petty. There is always room for improvement at Habbox but there is a fine line between expressing your ideas on improving the fansite and just trying to provoke / embarrass another individual. You easily could have addressed your coding concerns directly to myself and we could have resolved them together (teamwork for the win!). Instead you decided to post rudely on the forum which then escalated into a very annoying and completely unproductive discussion where you proceeded to point out my alleged "coding errors" publicly.

2. You might have been able to convince me that I had lazy comments, or that I maybe even used bland variable names but you should have stopped when you were ahead:

It gets worse than that, a variable which stores the number of minutes was "$hours"

I searched my entire Habbox project for use of a variable called $hours, I even searched old backups of such a variable and I came up with no related matches. I'm not going to accuse you of stretching the truth or blatantly lying here although I do not like the idea that you've attempted to publicly pin a very minor coding error on me that I am not even the creator of.

3. If you cannot stand the heat, you should not be in the kitchen. I'm going to pursue an eye for an eye justice here and point out that you called my comments and variables vague which made my code difficult for you to understand yet here I am attempting to breeze through your rarevalues plugin on the Habbox Wiki which you designed and it consists of 161 lines of non-tabbed code and in some areas completely incorrectly tabbed and spaced code. Descriptive comments are important and you are correct in saying so, but they mean nothing if your code is poorly strung together to create an illegible monster. You also made a comment about me saying I should learn to type cast (despite PHP handling implicit typecasts automatically), and I could make a comment about you saying you should learn to use quick ifs and not to use double quotes.

My point here is, I am not the best software designer in the world and you are not the best software designer in the world. I'm going to consider the events of this thread as a one time deal because I for one do not wish to frequently involve myself in feedback forum discussions where attacking each other's coding capabilities is the norm especially when neither of us is more qualified than the other. If it would please you, I would be more than happy to reinstate the staff coders forum where we could entertain ourselves for $hours by debating technique with each other, and so we could have an area on the forum to discuss the possibility of group tasks and working together. Naturally, Rob (or I believe he prefers weed man) and Ryan would be invited too.

Thread Closed.