Haven't actually tested anything, just flicked through the code. It's actually pretty good, much better than most of the code that turns up around here. Some general critique:
- Function and class naming is a little cryptic, an abbreviation or acronym may seem obvious to you but it does make the code much less readable, in the long run readability trumps speed to code. It's particularly helpful down the line when you have to understand your old code.
- Lots of documentation, which is great, just not phpDoc which is now the defacto standard
- Commenting on the other hand is a bit mixed, sometimes it's a bit.. redundent e.g.
PHP Code:
//-------------------------------
// Setup vars object
//
$this->vars = new StdClass();
I'm not entirely convinced you needed a three line comment for a self-explanatory statement.
- MySQL prepared statements are god, do make use of them
- Minor niggle: Your html comments are slightly malformed, you're occasionally adding additional hyphens which is ok but certainly for the closing tag is technically off html specification and my IDE was not happy about it.
Probably the biggest complaint, and in many ways it isn't one, is a lot of it is reinventing the wheel. Whilst for a learning experience this is certainly commendable I would recommend to anyone looking at this to consider other, more reputable, more tested CMS. Directly to you I would say looking at developing on top of a framework would be a more sensible approach to the problem than doing everything yourself.
Looking for Beta Testers for Radio Panel
Posting Permissions
Reply With Quote
